run-script vault fix, add run-script --no-deps option
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emk
suggested changes
Oct 6, 2017
There was a problem hiding this comment.
This PR combines two different changes:
- The
no-depschange, which I want to have a design discussion about before merging. - The
should_output_projectproject change, which we've discussed previously, and which I strongly suspect is an incorrect solution here. This is going to require me to re-read a bunch of code very carefully, and the patch will need a commit message justifying why the chosen solution is the correct one. The underlying issue may be a bug elsewhere incage's design, and I'd prefer to fix it there.
Please consider splitting out these two patches into separate PRs so we can discuss them individually. Thank you!
|
Closing in favor of #80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.