Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: part.type for easy type narrowing #422

Merged
merged 5 commits into from
Mar 13, 2023
Merged

feat: part.type for easy type narrowing #422

merged 5 commits into from
Mar 13, 2023

Conversation

nadhifikbarw
Copy link
Contributor

Easier type narrowing as discussed #144

Checklist

@nadhifikbarw
Copy link
Contributor Author

Before
image

After
image

mcollina
mcollina approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

climba03003
climba03003 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks better.

Uzlopak
Uzlopak requested changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicking on the typings tests, other than LGTM. Nice work.

@nadhifikbarw
Copy link
Contributor Author

@Uzlopak thanks! that was my initial approach, I thought it won't work since my IDE showing error, but it was only my cache issue.

Uzlopak
Uzlopak approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 3042c08 into fastify:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@climba03003 climba03003 climba03003 approved these changes

@StarpTech StarpTech Awaiting requested review from StarpTech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nadhifikbarw @mcollina @Uzlopak @climba03003