🚧 WIP: added Rollup Analyzer for bundle analysis #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caveats: * analyzer options (limit, filter, suppress) should be configurable - but how/where? * ideally, low-level modules like `lib/bundle/bundler.js` shouldn't be responsible for printing user-facing messages (in this case, I didn't want to pass through `bundle` - but perhaps there's a more elegant way after all?) * `configDir` needs to be passed through for use as `root` (cf. inline comment; I just haven't gotten around to doing that yet) as suggested by @moonglum
|
If it doesn't take treeshaking into account, then it is misleading and we should not include it IMHO. |
|
Let's see whether there's anything to be done about that: doesdev/rollup-analyzer#3 |
|
superseded by #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit message for details; suggestions welcome
npm testprovides a basic impression of what it looks likecaveat: It looks like tree shaking is not being taken into account, which makes results questionable.
(The bundle's actual size is just 0.5 kB.)