Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugh navigation changes #129

Open
wants to merge 10 commits into
base: development
Choose a base branch
from
Open

Conversation

HartiganHM
Copy link
Member

Navigation functionality/sytle updates


Description

Functional and stylistic updates to any navigation components as they are tested with Wavez.


Changes

  • Updates dark styles for SideNavigation

Fixes

  • Updates failing Button component tests

Screenshots

Screenshot description


Sanity Checks

  • There are no incidental style changes

@HartiganHM HartiganHM added 💅 Styling Styles need to be added, improved, or updated 🧪 Testing New or updates tests and testing infrastructure labels Dec 1, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

Canary release 🐥

To test your changes, run the below in a test repo:

yarn add @f-design/component-library@4.0.0-canary-HartiganHM-25bd07a8-b85a-5753-866a-4cdc6ff52f14.0

@cypress
Copy link

cypress bot commented Dec 1, 2021



Test summary

121 0 0 0Flakiness 0


Run details

Project Component Library
Status Passed
Commit 2840408 ℹ️
Started Dec 1, 2021 7:25 PM
Ended Dec 1, 2021 7:28 PM
Duration 02:51 💡
OS Linux Ubuntu - 20.04
Browser Chrome 96

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💅 Styling Styles need to be added, improved, or updated 🧪 Testing New or updates tests and testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant