Snappy is not enabled by default in cmake build, enable it #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lack of snappy compression is an issue for using rust-rdkafka in my organisation. While we deploy to linux, where we could use the mklove-based librdkafka-build, our developers mostly run Windows, where only the CMake-based librdkafka-build is available. I'm not familiar at all with the mklove build system, but from what I can tell, the mklove system also enables snappy by default (hard-coded). What would it take for this to get merged? Probably an entry in the changelog? I'm happy to help (obviously can't push to this PR directly) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason librdkafka's cmake build does not enable snappy compression support.
This enables snappy unconditionally (because anyway it is not an external dependency)