-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Sharing fedoralovespython on social media #31
base: master
Are you sure you want to change the base?
Conversation
TODO: check the description please |
Enable pretty Twitter and FB formatting. Add new image for sharing (fedoralovespython-share.jpg) only JPEG images are allowed Add metadata for FB and twitter validated with https://cards-dev.twitter.com/validator (Twitter) and https://developers.facebook.com/tools/debug/og/object/ Facebook validator shows some warnings which can be ignored: http://stackoverflow.com/questions/16475336/open-graph-twitter-cards-html5-incompatible Related issue: fedora-python#25
- smaller margins
Could you plese do a deploy as described in https://github.com/fedora-python/fedoralovespython.org#hacking ? If there is anything unclear about it, ask and I'll update the instructions. |
templates/index.html
Outdated
<!-- For Facebook and Twitter: --> | ||
<meta property="og:type" content="article"> | ||
<meta property="og:title" content="Fedora Loves Python - fedoralovespython.org"> | ||
<meta property="og:description" content="Fedora’s relationship with Python is very close, making it probably the best platform for developing with Python - learn why!"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd drop the probably
- let us brag a little.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/-/–/ here as well
templates/index.html
Outdated
@@ -4,6 +4,16 @@ | |||
<link href="{{ url_for('static', filename='style.css') }}" rel="stylesheet"> | |||
<link href="{{ url_for('static', filename='favicon.ico') }}" rel="shortcut icon" type="image/x-icon"> | |||
<link href='https://fonts.googleapis.com/css?family=Open+Sans:400,400italic,600,600italic&subset=latin' rel='stylesheet' type='text/css'> | |||
<!-- For Facebook and Twitter: --> | |||
<meta property="og:type" content="article"> | |||
<meta property="og:title" content="Fedora Loves Python - fedoralovespython.org"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/-/–/
templates/index.html
Outdated
<meta property="og:type" content="article"> | ||
<meta property="og:title" content="Fedora Loves Python - fedoralovespython.org"> | ||
<meta property="og:description" content="Fedora’s relationship with Python is very close, making it probably the best platform for developing with Python - learn why!"> | ||
<meta property="og:url" content="https://fedoralovespython.org/"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be the pages's url? There's also /__future__/
<meta property="og:type" content="article"> | ||
<meta property="og:title" content="Fedora Loves Python – fedoralovespython.org"> | ||
<meta property="og:description" content="Fedora’s relationship with Python is very close, making it the best platform for developing with Python - learn why!"> | ||
<meta property="og:url" content="https://fedoralovespython.org/"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shall be with __future__
on the __future__
page
@nmilosev what's the status? |
I completely forgot about this. :( I think it's pretty complete, just needs a final check from you. That is of course if the API hasn't changed. :D We lost a lost of time trying to setup my GH pages last time, so maybe it's better if you can finish this one off. As far as I can remember the only thing needed doing is changing the hardcoded link in the template. If you need help, please let me know. :) |
Enable pretty Twitter and FB formatting.
Add new image for sharing (fedoralovespython-share.jpg)
Add metadata for FB and twitter
https://developers.facebook.com/tools/debug/og/object/
Facebook validator shows some warnings which can be ignored:
Related issue: #25