ignore emit in closed cubit #4187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
requested changes
Jun 11, 2024
There was a problem hiding this comment.
I don't think this is the right change. The bloc and cubit behavior is inconsistent because there is a slight delay when adding an event due to the Event stream/sink not because the emit behavior is different. If we are to adjust this it should likely be in BlocBase. I'm going to close this for now since I want to take some time to consider the implications of this change before proceeding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
IN DEVELOPMENT
Breaking Changes
YES
Description
This change will solve the inconsistency between Bloc and Cubit if emit is used after the Bloc/Cubit is closed. (Issue #4165)
The added emit override makes sure no error is thrown if emit is called and the cubit is already closed. Instead, the emit will be simply ignored just like a Bloc.
Type of Change