Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better bfabric-cli api read command #138

Merged
merged 10 commits into from
Feb 10, 2025
Merged

Better bfabric-cli api read command #138

merged 10 commits into from
Feb 10, 2025

Conversation

leoschwarz
Copy link
Collaborator

@leoschwarz leoschwarz commented Feb 7, 2025

This improves the command in several ways:

  • Removes the automatic output type
  • Multiple values can be submitted for the same key
  • The query will be printed as a line of bfabricPy code
  • --file parameter to write the output to a specific file
  • Argument parsing is handled with pydantic now
  • Added tsv support

@leoschwarz
Copy link
Collaborator Author

@CodingKaiser I've went ahead and added what we discussed and some more to the bfabric-cli api read command, cleaning up some of the problems that I wanted to change anyways.

The remaining thing which is not handled consistently is when nested values get flattened. Right now it's never except when you export a .tsv.

Otherwise, what remains is to add some tests.

@leoschwarz leoschwarz marked this pull request as ready for review February 7, 2025 16:19
@leoschwarz leoschwarz merged commit 5fc2949 into main Feb 10, 2025
3 checks passed
@leoschwarz leoschwarz deleted the better-read branch February 10, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant