Skip to content

Commit

Permalink
Improved usage of ThreadChecker
Browse files Browse the repository at this point in the history
  • Loading branch information
kshalnev authored and syershov committed Mar 23, 2016
1 parent f872193 commit a6c6e2c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
18 changes: 9 additions & 9 deletions storage/http_map_files_downloader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ namespace storage
{
HttpMapFilesDownloader::~HttpMapFilesDownloader()
{
ASSERT(m_checker.CalledOnOriginalThread(), ());
ASSERT_THREAD_CHECKER(m_checker, ());
}

void HttpMapFilesDownloader::GetServersList(int64_t const mapVersion, string const & mapFileName,
TServersListCallback const & callback)
{
ASSERT(m_checker.CalledOnOriginalThread(), ());
ASSERT_THREAD_CHECKER(m_checker, ());
m_request.reset(downloader::HttpRequest::PostJson(
GetPlatform().MetaServerUrl(), strings::to_string(mapVersion) + '/' + mapFileName,
bind(&HttpMapFilesDownloader::OnServersListDownloaded, this, callback, _1)));
Expand All @@ -29,34 +29,34 @@ void HttpMapFilesDownloader::DownloadMapFile(vector<string> const & urls, string
TFileDownloadedCallback const & onDownloaded,
TDownloadingProgressCallback const & onProgress)
{
ASSERT(m_checker.CalledOnOriginalThread(), ());
ASSERT_THREAD_CHECKER(m_checker, ());
m_request.reset(downloader::HttpRequest::GetFile(
urls, path, size, bind(&HttpMapFilesDownloader::OnMapFileDownloaded, this, onDownloaded, _1),
bind(&HttpMapFilesDownloader::OnMapFileDownloadingProgress, this, onProgress, _1)));
}

MapFilesDownloader::TProgress HttpMapFilesDownloader::GetDownloadingProgress()
{
ASSERT(m_checker.CalledOnOriginalThread(), ());
ASSERT_THREAD_CHECKER(m_checker, ());
return m_request->Progress();
}

bool HttpMapFilesDownloader::IsIdle()
{
ASSERT(m_checker.CalledOnOriginalThread(), ());
ASSERT_THREAD_CHECKER(m_checker, ());
return m_request.get() == nullptr;
}

void HttpMapFilesDownloader::Reset()
{
ASSERT(m_checker.CalledOnOriginalThread(), ());
ASSERT_THREAD_CHECKER(m_checker, ());
m_request.reset();
}

void HttpMapFilesDownloader::OnServersListDownloaded(TServersListCallback const & callback,
downloader::HttpRequest & request)
{
ASSERT(m_checker.CalledOnOriginalThread(), ());
ASSERT_THREAD_CHECKER(m_checker, ());
vector<string> urls;
GetServerListFromRequest(request, urls);
callback(urls);
Expand All @@ -65,15 +65,15 @@ void HttpMapFilesDownloader::OnServersListDownloaded(TServersListCallback const
void HttpMapFilesDownloader::OnMapFileDownloaded(TFileDownloadedCallback const & onDownloaded,
downloader::HttpRequest & request)
{
ASSERT(m_checker.CalledOnOriginalThread(), ());
ASSERT_THREAD_CHECKER(m_checker, ());
bool const success = request.Status() != downloader::HttpRequest::EFailed;
onDownloaded(success, request.Progress());
}

void HttpMapFilesDownloader::OnMapFileDownloadingProgress(
TDownloadingProgressCallback const & onProgress, downloader::HttpRequest & request)
{
ASSERT(m_checker.CalledOnOriginalThread(), ());
ASSERT_THREAD_CHECKER(m_checker, ());
onProgress(request.Progress());
}
} // namespace storage
2 changes: 1 addition & 1 deletion storage/http_map_files_downloader.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ class HttpMapFilesDownloader : public MapFilesDownloader

unique_ptr<downloader::HttpRequest> m_request;

ThreadChecker m_checker;
DECLARE_THREAD_CHECKER(m_checker);
};
} // namespace storage

0 comments on commit a6c6e2c

Please sign in to comment.