fix: typos in documentation files #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following access changes will be introduced as a result of applying the plan: Access Changes |
|
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansfilecoin-project |
|
@Stebalien Hi, Is everything okay or do I need to fix something? |
|
Sorry, I thought this was a PR against a different repo. |
Stebalien
reviewed
Dec 2, 2024
README.md
Outdated
| @@ -15,22 +15,22 @@ To learn more, check out: | |||
| ## Tips / FYIs | |||
| * [github/filecoin-project.yml](https://github.com/filecoin-project/github-mgmt/blob/master/github/filecoin-project.yml) is the key file where updates are made to adjust permissions. | |||
| * "github-mgmt" was the old name. The original template repo is now called "github-as-code". We use the terms interchangably in comments/docs. | |||
| * Yes, it's confusing to have a `.github` and `github` directory. That is how gitub-mgmt was originally setup an we're living with it. (At least of 2024-09-05, there is [no backlog item for cleaning this up](https://github.com/ipdxco/github-as-code/issues?page=1&q=is%3Aissue+is%3Aopen).) | |||
| * Yes, it's confusing to have a `.github` and `github` directory. That is how GitHub-mgmt was originally setup an we're living with it. (At least of 2024-09-05, there is [no backlog item for cleaning this up](https://github.com/ipdxco/github-as-code/issues?page=1&q=is%3Aissue+is%3Aopen).) | |||
There was a problem hiding this comment.
Suggested change
| * Yes, it's confusing to have a `.github` and `github` directory. That is how GitHub-mgmt was originally setup an we're living with it. (At least of 2024-09-05, there is [no backlog item for cleaning this up](https://github.com/ipdxco/github-as-code/issues?page=1&q=is%3Aissue+is%3Aopen).) | |
| * Yes, it's confusing to have a `.github` and `github` directory. That is how `github-mgmt` was originally setup an we're living with it. (At least of 2024-09-05, there is [no backlog item for cleaning this up](https://github.com/ipdxco/github-as-code/issues?page=1&q=is%3Aissue+is%3Aopen).) |
Stebalien
approved these changes
Dec 2, 2024
BigLep
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
I'll approve / merge. Some of these changes should be made in https://github.com/ipdxco/github-as-code where this was forked/synced from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains changes to improve clarity, correctness and structure.
Description correction:
Corrected "gitub-mgmt" to "GitHub-mgmt".
Corrected "expecations" to "expectations".
Corrected "insallations" to "installations".
Corrected "Confrim" to "Confirm".
Corrected "modifes" to "modifies".
Corrected "worfklows" to "workflows".
Please review the changes and let me know if any additional changes are needed.