Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): go list check versions available for untagged dependencies #12774

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Dec 12, 2024

This is on top of #12740, I'm experimenting with using go list -versions to inspect v0.0.0 dependencies (as per discussion with @BigLep). We should be able to say "you're using an untagged version, but it has a version, that's naughty.

@rvagg rvagg requested a review from galargh December 12, 2024 01:01
@rvagg rvagg force-pushed the rvagg/ci/dependency-checker branch from 55edcd9 to cf21ec5 Compare December 12, 2024 01:28
@rvagg
Copy link
Member Author

rvagg commented Dec 12, 2024

OK, this works now and reports:

v0.0.0 dependencies with available tags:
github.com/hannahhoward/go-pubsub
howett.net/plist

first one is a direct dependency and the second is an indirect; I've added an ignore to both, pubsub could be upgraded but I won't do it here, the other one is used by github.com/elastic/go-sysinfo which has an update but still doesn't use a tagged version of plist.

@rvagg rvagg marked this pull request as ready for review December 12, 2024 01:29
@rvagg rvagg requested review from BigLep and Stebalien December 12, 2024 01:29
@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Dec 12, 2024
go.mod Outdated Show resolved Hide resolved
@BigLep
Copy link
Member

BigLep commented Dec 17, 2024

I'll handle merge conflicts this week per #12740 (comment)

@rvagg rvagg force-pushed the rvagg/ci/dependency-checker branch from cf21ec5 to e125c6e Compare December 18, 2024 05:59
@rvagg rvagg merged commit 87d5e41 into ci/dependency-checker Dec 18, 2024
77 checks passed
@rvagg rvagg deleted the rvagg/ci/dependency-checker branch December 18, 2024 06:02
rvagg added a commit that referenced this pull request Dec 18, 2024
…12740)

* feat(ci): go list check versions available for untagged dependencies (#12774)

---------

Co-authored-by: Steve Loeppky <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants