feat(fdc): Data Connect Dart SDK init #13063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cynthiajoan
reviewed
Jul 16, 2024
packages/firebase_data_connect/firebase_data_connect/protos/google/api/README.md
Outdated
Show resolved
Hide resolved
cynthiajoan
changed the title
cynthiajoan
reviewed
Jul 16, 2024
packages/firebase_data_connect/firebase_data_connect/example/pubspec.yaml
Outdated
Show resolved
Hide resolved
cynthiajoan
reviewed
Jul 16, 2024
packages/firebase_data_connect/firebase_data_connect/lib/src/core/ref.dart
Outdated
Show resolved
Hide resolved
cynthiajoan
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Let's try to fix the analyzer etc. Also would like to check if the code is up to date with the api review change.
@russellwheatley @Lyokone Can you help please audit the review comments in the doc that you've composed, and move the still valid ones here? Thanks!
Lyokone
reviewed
Aug 29, 2024
| @@ -0,0 +1,91 @@ | |||
| # Copyright 2021 The Chromium Authors. All rights reserved. | |||
There was a problem hiding this comment.
Even if we want to ignore the generated files in the linter?
packages/firebase_data_connect/firebase_data_connect/example/android/app/google-services.json
Outdated
Show resolved
Hide resolved
packages/firebase_data_connect/firebase_data_connect/example/dataconnect.yaml
Show resolved
Hide resolved
...irebase_data_connect/example/dataconnect/src/main/java/com/myapplication/AddMovieMutation.kt
Outdated
Show resolved
Hide resolved
packages/firebase_data_connect/firebase_data_connect/example/ios/firebase_app_id_file.json
Outdated
Show resolved
Hide resolved
packages/firebase_data_connect/firebase_data_connect/example/lib/main.dart
Outdated
Show resolved
Hide resolved
packages/firebase_data_connect/firebase_data_connect/example/lib/main.dart
Outdated
Show resolved
Hide resolved
| // limitations under the License. | ||
|
|
||
| /// version number for the package, should be align with pubspec.yaml. | ||
| const packageVersion = '0.1.0'; |
There was a problem hiding this comment.
We can probably do a script to update this version automatically on release (not important for first version)
Removed references to personal firebase projects Moved mapped host logic to new firebase_common package
cynthiajoan
reviewed
Sep 4, 2024
cynthiajoan
reviewed
Sep 6, 2024
packages/firebase_data_connect/firebase_data_connect/CHANGELOG.md
Outdated
Show resolved
Hide resolved
cynthiajoan
reviewed
Sep 6, 2024
packages/firebase_data_connect/firebase_data_connect/example/.vscode/settings.json
Outdated
Show resolved
Hide resolved
cynthiajoan
reviewed
Sep 6, 2024
packages/firebase_data_connect/firebase_data_connect/example/linux/.gitignore
Outdated
Show resolved
Hide resolved
cynthiajoan
reviewed
Sep 6, 2024
packages/firebase_data_connect/firebase_data_connect/example/windows/.gitignore
Outdated
Show resolved
Hide resolved
cynthiajoan
reviewed
Sep 6, 2024
packages/firebase_data_connect/firebase_data_connect/pubspec.yaml
Outdated
Show resolved
Hide resolved
cynthiajoan
approved these changes
Sep 6, 2024
Lyokone
approved these changes
Sep 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core SDK: packages/firebase_data_connect/firebase_data_connect/lib
Generated SDK: packages/firebase_data_connect/firebase_data_connect/example/lib/generated
Example: packages/firebase_data_connect/firebase_data_connect/example/lib
Context doc: go/dataconnect:sdk:dart:core