Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump iOS SDK to version 11.2.0 #13338

Merged
merged 9 commits into from
Sep 24, 2024
Merged

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Sep 16, 2024

Description

Bumping should fix phone auth issue on iOS.

Tested frameworks 11.2.0 locally and it works, so just a case of getting CI to go green here.

Related Issues

Related to FF issue:
fixes #13285
fixes #13284
fixes #13379
Related to firebase iOS SDK issue: firebase/firebase-ios-sdk#13479

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added the blocked: do-not-merge PR blocked externally label Sep 16, 2024
@russellwheatley russellwheatley removed the blocked: do-not-merge PR blocked externally label Sep 17, 2024
@OliverNarramore
Copy link

Would this fix - #13357 ?

@ariburgos
Copy link

Can we prioritize this PR??

Firebase iOS SDK has a lot of fixes between 11.0 and 11.2 https://firebase.google.com/support/release-notes/ios

@russellwheatley
Copy link
Member Author

something odd going on with iOS e2e tests (not firestore e2e). I ran locally and they were successful:
Screenshot 2024-09-24 at 13 55 31

@russellwheatley russellwheatley merged commit ff1e5f6 into main Sep 24, 2024
27 of 29 checks passed
@russellwheatley russellwheatley deleted the firebase-ios-sdk-11.2.0 branch September 24, 2024 16:21
@cyberpwnn
Copy link

Ended up just breaking release mode again. Congrats!

@firebase firebase locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants