Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage, web): use universal_io in the barrel file of firebase_storage #13507

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(storage, web): use universal_io in the barrel file of firebase_storage #13507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1160ba7
chore(storage, web): remove io dummy export throught the barrel file …
Lyokone Oct 16, 2024
6f6b33a
use universal_io
Lyokone Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/firebase_storage/firebase_storage/lib/firebase_storage.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,14 @@ library firebase_storage;

import 'dart:async';
import 'dart:convert' show utf8, base64;
import 'dart:io' show File;
// TODO(Lyokone): remove once we bump Flutter SDK min version to 3.3
// ignore: unnecessary_import
import 'dart:typed_data' show Uint8List;

// import 'package:flutter/foundation.dart';
import 'package:firebase_core/firebase_core.dart';
import 'package:firebase_core_platform_interface/firebase_core_platform_interface.dart'
show FirebasePluginPlatform;
import 'package:firebase_storage_platform_interface/firebase_storage_platform_interface.dart';
import 'package:flutter/foundation.dart';
import 'package:universal_io/io.dart' show File;

import 'src/utils.dart';

Expand Down
2 changes: 2 additions & 0 deletions packages/firebase_storage/firebase_storage/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ dependencies:
firebase_storage_web: ^3.10.3
flutter:
sdk: flutter
# Used to expose File even when web isn't supported
universal_io: ^2.2.2

dev_dependencies:
flutter_test:
Expand Down
Loading