Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention non-specific method exception codes #3317

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

Ehesp
Copy link
Member

@Ehesp Ehesp commented Aug 24, 2020

Description

Mention non-specific method exception codes in the documentation.

Related Issues

Fixes #3273

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@github-actions
Copy link

Deploy preview for 7dd254d:

https://flutter-firebase-docs--pr3317-docs-3273-bhi8ins1.web.app

(expires Mon, 31 Aug 2020 11:48:36 GMT)

firebase-hosting-preview-action

@Salakar Salakar changed the title mention non-specific method exception codes docs: mention non-specific method exception codes Aug 24, 2020
@Salakar Salakar added the type: documentation Improvements or additions to documentation label Aug 24, 2020
@Salakar Salakar merged commit 0704448 into master Aug 24, 2020
@Salakar Salakar deleted the docs-3273 branch August 24, 2020 22:57
@feinstein
Copy link
Contributor

feinstein commented Aug 24, 2020

This PR doesn't include changes into FirebaseAuthException as requested by @Ehesp in #3273 here.

@Salakar
Copy link
Member

Salakar commented Aug 24, 2020

Reopened original issue to track, it got automatically closed when this one was merged 🙈

@firebase firebase locked and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firebase_auth] Missing Exceptions
4 participants