-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix boolean argument in Nair Lauritzen divergent #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tim for spotting that this wasn't working.
Two main things:
- can you apply the same change to the non-divergent test?
- can you update the calls in the
test_transport.py
file?
@@ -61,6 +61,8 @@ def nair_lauritzen_divergent( | |||
# Our settings for this set up | |||
# ------------------------------------------------------------------------ # | |||
|
|||
print(no_background_flow) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I have a habit of doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tim!
Set the boolean argparse option of --background_flow to default to False. This means that both false and true (--background_flow=True) configurations can be run, whereas previously it became True irrespective of command line input.