Add background wind to divergent Nair-Lauritzen test case #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ta440
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
This all looks good to me. Thanks for removing the whitespaces that I'd left in!
One possible addition is whether we make a user defined boolean variable for whether we have a background flow, e.g. 'background=True', as the Nair Lauritzen paper has cases with and without a background flow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a solid-body zonal background wind to the divergent Nair-Lauritzen test case (there is already one in the non-divergent case). I also added a limiter as I was running it with the cylinders!
My text editor also seems to have removed a bunch of white space and highlighted some unused imported variables.
Here are some plots (note I ran this on the cubed sphere, but in the script here it is the icosahedral sphere)