-
-
Notifications
You must be signed in to change notification settings - Fork 81.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shashankdangi/add blue sky sharelink Addresses #91497 #91518
Shashankdangi/add blue sky sharelink Addresses #91497 #91518
Conversation
…e logos and also to the options of share
Thank you for your pull request. This pull request contains changes in files which requires review. The following files were changed:
|
@@ -1,6 +1,7 @@ | |||
# Contributors | |||
- Hey there, I'm Harsh Patel. Let the world know, this is my first commit, marking the start of an incredible journey into open source! 🌟 Check out my [GitHub](https://github.com/cm-harshpatel)! **You are capable of amazing things; keep shining and making the world brighter!** | |||
- Hi, I am NNS from Myanmar (https://github.com/NyeinNyein88/) | |||
- Hi , I'm Shashank[シャシャンク] from Osaka , Japan .[Github](https://github.com/shashankdangi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not relevant to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making these changes. I've added some minor review comments.
Also please test it out and share a link to a PR where this worked correctly
…hare list into bulleted list , swapped twitter and blueSky order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the review Changes
Added the necessary changes . |
@@ -101,6 +101,9 @@ jobs: | |||
const linkedin_share_link = 'https://www.linkedin.com/sharing/share-offsite/?url=https://github.com/firstcontributions/first-contributions'; | |||
const dev_share_link = "https://dev.to/new?prefill=---%0Atitle%3A%20First%20Contributions%3A%20learn%20how%20to%20contribute%20to%20open%20source%20projects%0Apublished%3A%20true%0Atags%3A%20opensource%2C%20beginners%2C%20tutorial%0A---%0A%0AI%20followed%20the%20hands-on%20tutorial%20in%20the%20Readme%20of%20first%20contributions%20and%20made%20my%20first%20pull%20request%20to%20the%20same%20repo.%0A%0A%0A%7B%25%20embed%20https%3A%2F%2Fgithub.com%2Ffirstcontributions%2Ffirst-contributions%20%25%7D"; | |||
const hackernews_share_link = 'https://news.ycombinator.com/submitlink?u=https%3A%2F%2Fgithub.com%2Ffirstcontributions%2Ffirst-contributions&t=Show%20HN%3A%20Hands%20on%20tutorial%20for%20open%20source%20contribution' | |||
const bluesky_share_link = 'https://bsky.app/intent/compose?text=I%20just%20made%20my%20first%20contribution%20to%20open%20source%20with%20First%20Contributions!%20🎉%20Check%20it%20out:%20https%3A%2F%2Fgithub.com%2Ffirstcontributions%2Ffirst-contributions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const bluesky_share_link = 'https://bsky.app/intent/compose?text=I%20just%20made%20my%20first%20contribution%20to%20open%20source%20with%20First%20Contributions!%20🎉%20Check%20it%20out:%20https%3A%2F%2Fgithub.com%2Ffirstcontributions%2Ffirst-contributions | |
const bluesky_share_link = 'https://bsky.app/intent/compose?text=I%20just%20made%20my%20first%20contribution%20to%20open%20source%20with%20First%20Contributions%21%20%F0%9F%8E%89%20Check%20it%20out%3A%0A%0A%0Ahttps%3A%2F%2Fgithub.com%2Ffirstcontributions%2Ffirst-contributions%2F%0A%0A%0A%23opensource |
|
Addresses the issuee #91497