Add bluesky sharing(addresses #91497) #92054
Conversation
|
Thank you for your pull request. This pull request contains changes in files which requires review. The following files were changed:
|
|
Hi @Roshanjossey , Could you please take a look at this pull request when you have a moment? Best, |
There was a problem hiding this comment.
Hi Fahad,
You have declared variables for bluesky but hasn't used it.
Check line 124 starting with const nextSteps and how other links and logos are used there.
Some suggestions
- Could you change the share links so that they're in a bulleted list?
- Let's put Bluesky link on top
Here's a similar PR for reference https://github.com/firstcontributions/first-contributions/pull/91518/files
.github/workflows/auto-pr-merge.yml
Outdated
| @@ -111,6 +111,9 @@ jobs: | |||
| const linkedin_logo = "https://edent.github.io/SuperTinyIcons/images/svg/linkedin.svg"; | |||
| const dev_logo = "https://edent.github.io/SuperTinyIcons/images/svg/dev_to.svg"; | |||
| const hackernews_logo = "https://edent.github.io/SuperTinyIcons/images/svg/hackernews.svg"; | |||
| const bluesky_logo = "https://path-to-your-bluesky-logo.png"; | |||
| const bluesky_share_link = 'https://bsky.app/intent/compose?text=' + encodeURIComponent('Yay! I just made my first open source contribution with @firstcontributions. You can too at https://goo.gl/66Axwe #OpenSource #CodeNewbie'); | |||
There was a problem hiding this comment.
This link is correct. Could you move it to social media links section above?
.github/workflows/auto-pr-merge.yml
Outdated
| @@ -111,6 +111,9 @@ jobs: | |||
| const linkedin_logo = "https://edent.github.io/SuperTinyIcons/images/svg/linkedin.svg"; | |||
| const dev_logo = "https://edent.github.io/SuperTinyIcons/images/svg/dev_to.svg"; | |||
| const hackernews_logo = "https://edent.github.io/SuperTinyIcons/images/svg/hackernews.svg"; | |||
| const bluesky_logo = "https://path-to-your-bluesky-logo.png"; | |||
There was a problem hiding this comment.
logo url is wrong. Please use https://edent.github.io/SuperTinyIcons/images/svg/bluesky.svg
| const bluesky_logo = "https://path-to-your-bluesky-logo.png"; | |
| const bluesky_logo = "https://edent.github.io/SuperTinyIcons/images/svg/bluesky.svg"; |
There was a problem hiding this comment.
Hi @Roshanjossey , apologies for the mistake. Just fixed it. Please have a look when you can.
Thanks!
There was a problem hiding this comment.
No worries. The message hasn't been updated. Please check the PR I linked above for reference.
Also, please remove submodule inside
Addresses issue #91497 - Bluesky sharing option