Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Upgrade dashbook version #3109

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

immadisairaj
Copy link
Contributor

Description

This PR upgrades the dashbook to the latest version in the examples. After upgrading, the links related to this are also being updated in the docs. It also removes dashbook from dependencies of examples in forge2d as it no longer uses it.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • [-] Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Some parts of #2895 (like 5 and 6) are fixed
Closes #2790

Additional Details

Has a one line conflict with #3072 in other_inputs.md (should not be much of an issue)

with the latest changes in the dashbook, upgrading the examples
directory to the latest version
@immadisairaj immadisairaj changed the title docs: upgrade dashbook version docs: Upgrade dashbook version Mar 29, 2024
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@spydon spydon merged commit a717bcb into flame-engine:main Mar 29, 2024
8 of 9 checks passed
@immadisairaj immadisairaj deleted the dashbook-upgrade branch March 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stronger contrast on the chosen example title
2 participants