Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump vite to 6.0.0-beta.9 #58

Closed
wants to merge 2 commits into from
Closed

bump vite to 6.0.0-beta.9 #58

wants to merge 2 commits into from

Conversation

dario-piotrowicz
Copy link
Contributor

No description provided.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/bump-vite-to-beta9 branch 8 times, most recently from c8095f5 to a1b203c Compare November 12, 2024 04:15
@dario-piotrowicz dario-piotrowicz force-pushed the dario/bump-vite-to-beta9 branch 2 times, most recently from 69d14ca to 8a6e09c Compare November 12, 2024 04:26
@dario-piotrowicz dario-piotrowicz changed the title (WIP) bump vite to beta9 bump vite to 6.0.0-beta.9 Nov 12, 2024
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review November 12, 2024 04:41
jamesopstad
jamesopstad reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@jamesopstad jamesopstad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The move to using a single transport for fetching modules and HMR in 6.0.0-beta.9 is quite a big change. It's worth reading through the PR and code changes (vitejs/vite#18362).

What you've done here has inadvertently removed all support for HMR. I can't advise on what the best approach is overall until I've had a play around with it myself as there are a few possibilities.

I suggest we hold off on this for now and focus on merging the other PRs. It also reminded me of another longstanding issue we have with HMR so I've opened an issue for that (#64).

@dario-piotrowicz
Copy link
Contributor Author

What you've done here has inadvertently removed all support for HMR. I can't advise on what the best approach is overall until I've had a play around with it myself as there are a few possibilities.

Thanks for noticing that! Sorry I missed to check that as I didn't think any of my changes should effect HMR! (totally my bad 😓)

I will look into fixing HMR here as soon as I can.

By the way, I will also create an issue for HMR testing, I think we should definitely have some tests that do make sure that HMR works

@dario-piotrowicz dario-piotrowicz marked this pull request as draft November 13, 2024 22:45
@dario-piotrowicz
Copy link
Contributor Author

Closing in favour of #70

@dario-piotrowicz dario-piotrowicz deleted the dario/bump-vite-to-beta9 branch November 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesopstad jamesopstad jamesopstad left review comments

@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dario-piotrowicz @jamesopstad