add legacy option to send legacy txs
#54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @zzzzzzch thanks for the PR! Sorry it took me so long to get back to you -- I recently did a bunch of refactoring and wasn't sure how this would fit until later. This is a good idea, but I think it would be even better if instead of a boolean for legacy, we had an enum to support many tx types. That way, we don't have to add additional params later on; just more enum values. The codebase has been shuffled around quite a bit since you pushed this so you might want to start this on a fresh branch and cherry-pick the code you need from this PR, but it's up to you :) Looking forward to your next commits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a great perf tool. I found that spammer sends EIP-1559 txs by default, which is fine, but sometimes eth-forked/custom node clients may not support EIP-1559 and therefore it is needed to be specified to send legacy txs.
So this PR adds the
legacyoption to specify sending legacy txs.please review and feel free to comment.