-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issue-253): initial metrics implementation #686
base: develop
Are you sure you want to change the base?
Conversation
0a730ba
to
65d48a5
Compare
65d48a5
to
be38349
Compare
Are you planning expose MEV Boost metrics? |
Yes! i'd proposed a full integration that was rejected here a while back #294 on the grounds of the changes being too deep into the codebase
This MR is step 1 of the recommendation instrumentation is introduced gradually to reduce operator risk
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @0xste, this seems like a reasonable first step! Thanks. I've made some changes, please review if/when you have time.
📝 Summary
An initial prometheus http server exposed optionally on a custom port if flag is provided at runtime.
⛱ Motivation and Context
As per discussion on: #294 (comment) i've reduced the scope of the change to be as minimal as possible and look to incrementally add additional metrics over time to de-risk the implementation
Following the step 1 recommendation on: #253 (comment)
📚 References
#253
✅ I have run these commands
make lint
make test-race
go mod tidy