-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys-kernel/coreos-modules: Enable EFI_ZBOOT for arm64 #2507
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward. I'm happy if CI passes and the image changes look good. Have we got away with this before because the uncompressed arm64 kernel is just smaller than the amd64 one due to fewer drivers and such?
Arm64 now supports booting a compressed kernel through EFI. This is hidden behind the EFI_ZBOOT Kconfig option. The EFI_ZBOOT is only enabled in the arm64 config because it is not available for x86. X86 relies on an architecture specific compression mechanism on EFI. The KERNEL_ZSTD Kconfig option applies to both arches so move it to commonconfig. The other change required is that the kernel image name changes. In my local build it looks like the kernel size goes down from 59MB to 43MB. Signed-off-by: Jeremi Piotrowski <[email protected]>
Signed-off-by: Jeremi Piotrowski <[email protected]>
34d6219
to
d824d15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
Looks like grub 2.02 doesn't like the change:
This needs some investigation. This is from these test cases:
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/12241687577 |
Looks like this is what changed things: torvalds/linux@29636a5 So this is blocked until we come up with a solution. |
This is the grub commit that dropped the magic number check (using RH fork because the canonical grub repo is not on github): rhboot/grub2@69edb31 This went in between 2.06 and 2.12. |
Well, I wanted to chat to you about the upgrade path anyway. 😁 |
Enable EFI_ZBOOT for arm64
Arm64 now supports booting a compressed kernel through EFI. This is hidden behind the EFI_ZBOOT Kconfig option. The EFI_ZBOOT is only enabled in the arm64 config because it is not available for x86. X86 relies on an architecture specific compression mechanism on EFI. The KERNEL_ZSTD Kconfig option applies to both arches so move it to commonconfig. The other change required is that the kernel image name changes.
In my local build it looks like the kernel size goes down from 59MB to 43MB.
How to use
Build an arm64 image and boot it.
Testing done
Build tested only.
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.