Delay generating test update payload in official builds #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it uses the default name, which can clash with other concurrent jobs, especially jobs for the other arches. Signed-off-by: James Le Cuirot <[email protected]>
The update payload needs the kernel, which isn't signed during the image job. Secure Boot is not currently enabled for update tests, but we may as well do this properly. The production update upload is generated manually at the end after everything has already been signed. Signed-off-by: James Le Cuirot <[email protected]>
Once we have passed the shim review, we will delay this task until the kernel has been signed later in the pipeline. Signed-off-by: James Le Cuirot <[email protected]>
I know I recently deduplicated the code between extract_update and generate_update recently, but now that generate_update will sometimes be called at a later time, I've realised that it is compressing and uploading the partition twice. Signed-off-by: James Le Cuirot <[email protected]>
tormath1
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay generating test update payload in official builds
The update payload needs the kernel, which isn't signed during the image job. Secure Boot is not currently enabled for update tests, but we may as well do this properly. The production update upload is generated manually at the end after everything has already been signed.
However, we need to temporarily nobble part of the above change until we have actually passed the shim review.
This also fixes a container name clash in the sbsign_image job.
How to use
Nothing to do.
Testing done
I have run Jenkins for amd64 and arm64. The qemu_update tests passed. I also checked the timestamps of files on the bincache to ensure the right files were uploaded when expected.
changelog/directory (user-facing change, bug fix, security fix, update) -- N/A/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.N/A