Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for arches dir and set ARCHES_ROOT #7

Open
wants to merge 1 commit into
base: arches-7.6.0
Choose a base branch
from

Conversation

StuCM
Copy link

@StuCM StuCM commented Jan 13, 2025

Description

This checks to see if an arches repo lives in the parent directory.
If it does it sets ARCHES_ROOT to that directory, if not it sets it as an empty string

An additional docker-compose file has then been created which contains the additional volume mounts for ARCHES_ROOT. If the variable has been set, these are applied with the original in the volume mounts.

Test

Run a copy of arches without the base arches.
The instance should start without an ARCHES_ROOT error.
Add the arches root dir into the parent directory, add a log statement somewhere that will run
Restart the containers and see if the log statement is visible

Additional

I believe we may be able to adjust this to automatically build mounts for any apps that we want to install. If we set up an app dir in the parent directory we could build an additional docker compose to create the mount paths

@StuCM StuCM requested a review from philtweir January 13, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant