Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: restore email settings #477

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix: restore email settings #477

wants to merge 2 commits into from

Conversation

philtweir
Copy link
Contributor

What does this PR do?

Ensures that email settings are taken from environment variables, by pulling in ACT.

How to review?

Running this locally with docker-compose envs, it can be tested with mailtrap.

Who can review?

@StuCM @taylorn01 @OwenGalvia

@philtweir philtweir requested a review from StuCM October 1, 2024 08:54
StuCM
StuCM approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@StuCM StuCM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed that the static container is failing when building due to the email_backend variable. Should this be commented out for the build?
In order for this to work with mail trap I had to comment it out as well

StuCM
StuCM reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@StuCM StuCM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed that the static container is failing when building due to the email_backend variable. Should this be commented out for the build?
In order for this to work with mail trap I had to comment it out as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StuCM StuCM StuCM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philtweir @StuCM