Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null check on null value error in _onChangedClipboardStatus #454

Merged

Conversation

Amir-P
Copy link
Member

@Amir-P Amir-P commented Jan 31, 2025

Fixes #435

@Amir-P Amir-P requested a review from amantoux January 31, 2025 17:42
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.26%. Comparing base (2de5c31) to head (eb7e95e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   88.26%   88.26%           
=======================================
  Files          62       62           
  Lines       10656    10657    +1     
=======================================
+ Hits         9405     9406    +1     
  Misses       1251     1251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small question though, can you please take a look?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to put this in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not. If you find it inappropriate I can exclude the change. @amantoux

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind

@amantoux amantoux merged commit e904344 into master Jan 31, 2025
4 checks passed
@amantoux amantoux deleted the fix/null_check_on_null_value_on_changed_clipboard_status branch January 31, 2025 21:26
@amantoux amantoux restored the fix/null_check_on_null_value_on_changed_clipboard_status branch January 31, 2025 21:26
@Amir-P Amir-P deleted the fix/null_check_on_null_value_on_changed_clipboard_status branch February 1, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RawEditorState._onChangedClipboardStatus
2 participants