Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

param: cellpadding_x #1398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

param: cellpadding_x #1398

wants to merge 1 commit into from

Conversation

Grief
Copy link

@Grief Grief commented Aug 8, 2024

This allows to make the overlay smaller than it was possible before:
image

@flightlessmango
Copy link
Owner

What does this look like in horizontal and what happens with the recording dot?
Is cellpadding_x=1 the old default?

@Grief
Copy link
Author

Grief commented Aug 10, 2024

@flightlessmango it works the same way, allowing to make the layout more tight
image

or loose
image

the default is cellpadding_x=0 or not defined
image

@flightlessmango
Copy link
Owner

I guess my question is if you don't set cellpadding_x, will it have the old spacing?
And what value is the old spacing in cellpadding_x ?

params->width = params->font_size * params->font_scale * params->table_columns * 4.6;
const auto real_size = params->font_size * params->font_scale;

params->width = static_cast<uint>(((1.0 + params->cellpadding_x * 2.0) * 4.6) * real_size * params->table_columns);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mingw compiler doesn't recognize uint, casting as unsigned int should be more portable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants