Fix for Guice Wrapped Class #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bageshwar
requested changes
Dec 20, 2024
| @@ -80,6 +81,11 @@ private Map<DataAdapterKey<?>, Field> buildCacheOfMutableFields() { | |||
|
|
|||
| @SuppressWarnings("rawtypes") | |||
| public static String getEmittedDataName(Class<? extends DataAdapterBizlogic> clazz) { | |||
| if (clazz.getName().contains(BytecodeGen.ENHANCER_BY_GUICE_MARKER)) { | |||
There was a problem hiding this comment.
Let's also mention why this change was needed in comments
| @Override | ||
| public Object invoke(MethodInvocation invocation) throws Throwable { | ||
| // Log method details before invocation | ||
| System.out.println("Before test method invocation"); |
There was a problem hiding this comment.
Do we need this log lines?
| @@ -0,0 +1,96 @@ | |||
| package flipkart.tef.bizlogics; | |||
There was a problem hiding this comment.
Add copyright header (check peer class files)
| @@ -80,6 +81,11 @@ private Map<DataAdapterKey<?>, Field> buildCacheOfMutableFields() { | |||
|
|
|||
| @SuppressWarnings("rawtypes") | |||
| public static String getEmittedDataName(Class<? extends DataAdapterBizlogic> clazz) { | |||
There was a problem hiding this comment.
Can you check once if this method really has to be public? If not, can we make it private and run the test via reflection, or make it package private atleast.
There was a problem hiding this comment.
Its been used in FlowBuilder also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.