fixing lints

Signed-off-by: ryanohnemus <[email protected]>
fluent · Feb 3, 2024 · 6874330 · 6874330
1 parent 38f78e0
commit 6874330
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/helpers/test-helpers.bash b/helpers/test-helpers.bash
@@ -108,7 +108,9 @@ function create_helm_extra_values_file() {
     # by the test. This will fall back to $TEST_ROOT/defaults/values.yaml.tpl
     # if not passed.
     if [ -e  "${HELM_VALUES_EXTRA_FILE}" ]; then
+      # shellcheck disable=SC2155
       envsubst < "${HELM_VALUES_EXTRA_FILE}" > "$(dirname ${HELM_VALUES_EXTRA_FILE})/${TEST_NAMESPACE}.values.yaml"
+      # shellcheck disable=SC2086
       export HELM_VALUES_EXTRA_FILE="$(dirname ${HELM_VALUES_EXTRA_FILE})/${TEST_NAMESPACE}.values.yaml"
     fi
 }
diff --git a/run-tests.sh b/run-tests.sh
@@ -82,7 +82,7 @@ function run_tests() {
     # If TEST_NAMESPACE is not set (the default), we run jobs in parallel
     # otherwise, if it is set we can only run 1 job at a time and need to remove
     # all BATS_JOBS_PARAMS
-    if [[ ! -z "${TEST_NAMESPACE:-}" ]]; then
+    if [[ -n "${TEST_NAMESPACE:-}" ]]; then
         BATS_JOBS_PARAMS=""
     fi