Skip to content

Commit

Permalink
workflows: fix up linting
Browse files Browse the repository at this point in the history
Signed-off-by: Patrick Stephens <[email protected]>
  • Loading branch information
patrick-stephens committed Jan 27, 2025
1 parent f9ff41e commit 4f3a7d2
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions .github/workflows/call-build-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ jobs:
needs:
- call-build-images-meta
- call-build-single-arch-container-images
outputs:
version: ${{ steps.meta.outputs.version }}
steps:
- name: Extract metadata from Github
id: meta
Expand Down Expand Up @@ -205,6 +207,8 @@ jobs:
needs:
- call-build-images-meta
- call-build-single-arch-container-images
outputs:
version: ${{ steps.meta.outputs.debug-version }}

Check failure on line 211 in .github/workflows/call-build-images.yaml

View workflow job for this annotation

GitHub Actions / PR - Actionlint

property "meta" is not defined in object type {debug-meta: {conclusion: string; outcome: string; outputs: {annotations: string; bake-file: string; bake-file-annotations: string; bake-file-labels: string; bake-file-tags: string; json: string; labels: string; tags: string; version: string}}}
steps:
- id: debug-meta
uses: docker/metadata-action@v5
Expand Down Expand Up @@ -313,6 +317,7 @@ jobs:
needs:
- call-build-images-meta
- call-build-container-image-manifests
- call-build-debug-container-image-manifests
name: Deploy and sign multi-arch container image manifests
permissions:
contents: read
Expand All @@ -333,13 +338,13 @@ jobs:
#
# We use recursive signing on the manifest to cover all the images.
run: |
cosign sign --recursive \
cosign sign --recursive --force \
-a "repo=${{ github.repository }}" \
-a "workflow=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" \
-a "ref=${{ github.sha }}" \
-a "release=${{ inputs.version }}" \
"${{ inputs.registry }}/${{ inputs.image }}@${{ needs.call-build-images.outputs.production-digest }}" \
"${{ inputs.registry }}/${{ inputs.image }}@${{ needs.call-build-images.outputs.debug-digest }}"
"${{ inputs.registry }}/${{ inputs.image }}@${{ needs.call-build-container-image-manifests.outputs.version }}" \
"${{ inputs.registry }}/${{ inputs.image }}@${{ needs.call-build-debug-container-image-manifests.outputs.version }}"
shell: bash
# Ensure we move on to key-based signing as well
continue-on-error: true
Expand All @@ -352,13 +357,13 @@ jobs:
# The key needs to cope with newlines
run: |
echo -e "${COSIGN_PRIVATE_KEY}" > /tmp/my_cosign.key
cosign sign --key /tmp/my_cosign.key --recursive \
cosign sign --key /tmp/my_cosign.key --recursive --force \
-a "repo=${{ github.repository }}" \
-a "workflow=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" \
-a "ref=${{ github.sha }}" \
-a "release=${{ inputs.version }}" \
"${{ inputs.registry }}/${{ inputs.image }}@${{ needs.call-build-images.outputs.production-digest }}" \
"${{ inputs.registry }}/${{ inputs.image }}@${{ needs.call-build-images.outputs.debug-digest }}"
"${{ inputs.registry }}/${{ inputs.image }}@${{ needs.call-build-container-image-manifests.outputs.version }}" \
"${{ inputs.registry }}/${{ inputs.image }}@${{ needs.call-build-debug-container-image-manifests.outputs.version }}"
rm -f /tmp/my_cosign.key
shell: bash
continue-on-error: true
Expand Down

0 comments on commit 4f3a7d2

Please sign in to comment.