out_datadog: Add support for setting a static hostname #8988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for setting a static hostname in the Datadog output plugin. This field is analogous to the existing `dd_service` and `dd_source` configuration options that can be used to set a static value. If unset, the default behavior is backwards compatible. This behavior is to not set an explicity `hostname` field, but if the record has a field that is detected as the hostname in Datadog (such as `host` or `syslog.hostname`), it will be picked up. Closes: fluent#8971 Signed-off-by: Jesse Szwedko <[email protected]>
|
Example configuration file: pipeline:
inputs:
- name: dummy
tag: dummy
dummy: |
{
"message": "From Fluent Bit",
"test": "default"
}
outputs:
- name: datadog
match: "*"
apikey: ${DD_API_KEY}
dd_hostname: foobarYou can run this and observe that events published have their hostname detected as foobar: |
|
Debug output: |
|
Valgrind output: |
|
I tried to run |
|
Thank you so much for working on this! Please let me know if there's anything I can do to help this along. |
jszwedko
added a commit
to jszwedko/fluent-bit-docs
that referenced
this pull request
Jul 2, 2024
Added by fluent/fluent-bit#8988 Signed-off-by: Jesse Szwedko <[email protected]>
|
PR for docs: fluent/fluent-bit-docs#1401 |
jszwedko
added a commit
to DataDog/documentation
that referenced
this pull request
Jul 2, 2024
Added in fluent/fluent-bit#8988 Easiest to review with whitespace changes ignored Signed-off-by: Jesse Szwedko <[email protected]>
1 task
hestonhoffman
added a commit
to DataDog/documentation
that referenced
this pull request
Jul 9, 2024
* Document new `dd_hostname` field for fluentbit integration Added in fluent/fluent-bit#8988 Easiest to review with whitespace changes ignored Signed-off-by: Jesse Szwedko <[email protected]> * Update content/en/integrations/fluentbit.md --------- Signed-off-by: Jesse Szwedko <[email protected]> Co-authored-by: Heston Hoffman <[email protected]>
lecaros
pushed a commit
to fluent/fluent-bit-docs
that referenced
this pull request
Nov 29, 2024
* out_datadog: Document `dd_hostname` configuration option Added by fluent/fluent-bit#8988 Signed-off-by: Jesse Szwedko <[email protected]> * Update pipeline/outputs/datadog.md Co-authored-by: Craig Norris <[email protected]> Signed-off-by: Jesse Szwedko <[email protected]> * Added link Signed-off-by: Jesse Szwedko <[email protected]> --------- Signed-off-by: Jesse Szwedko <[email protected]> Signed-off-by: Jesse Szwedko <[email protected]> Co-authored-by: Craig Norris <[email protected]>
|
@jszwedko Can this be extended to index as well? We see it always set to main, which I'm guessing is the default, when we don't do anything. And we see two tags, one that says main and another with our defined index, when we try to set index with fluent bit but I don't think our defined index works. |
@ljp0101 I may be misunderstanding the request, but the index is not actually specified when sending logs to Datadog. Instead the index(es) are selected during ingestion based on the configuration in Datadog (see https://docs.datadoghq.com/logs/log_configuration/indexes/). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting a static hostname in the Datadog output plugin. This field is analogous to the existing
dd_serviceanddd_sourceconfiguration options that can be used to set a static value.If unset, the default behavior is backwards compatible. This behavior is to not set an explicity
hostnamefield, but if the record has a field that is detected as the hostname in Datadog (such ashostorsyslog.hostname), it will be picked up.Closes: #8971
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.