Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable old ms api endpoint #145

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: disable old ms api endpoint #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 3 additions & 24 deletions src/metar/metar.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,30 +53,9 @@ export class MetarService {
);
}

// MS
async fetchMsBlob(): Promise<string[]> {
const cacheHit = await this.cache.get<string[]>('/metar/blob/ms');

if (cacheHit) {
this.logger.debug('Returning from cache');
return cacheHit;
}
const data = await this.http.get<string>('https://fsxweatherstorage.blob.core.windows.net/fsxweather/metars.bin')
.pipe(
tap((response) => this.logger.debug(`Response status ${response.status} for MS METAR request`)),
map((response) => response.data.split(/\r?\n/)),
).toPromise();

this.cache.set('/metar/blob/ms', data, 240).then();
return data;
}

private handleMs(icao: string): Promise<Metar> {
return this.fetchMsBlob()
.then((response) => ({ icao, metar: response.find((x) => x.startsWith(icao)), source: 'MS' }))
.catch((e) => {
throw this.generateNotAvailableException(e, icao);
});
// The FSX weather data stopped updating since NOAA switched their API in October 2023.
throw new HttpException(`METAR not available for ICAO: ${icao}`, 404);
}

// IVAO
Expand Down Expand Up @@ -130,7 +109,7 @@ export class MetarService {
return ({
source: 'AviationWeather',
icao,
metar: metars.find((x) => x.startsWith(icao)).toUpperCase()
metar: metars.find((x) => x.startsWith(icao)).toUpperCase(),
});
}),
catchError(
Expand Down