Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unhijack globalShortcut & convert to local #466

Merged
merged 8 commits into from
Apr 14, 2024

Conversation

alepouna
Copy link
Member

@alepouna alepouna commented Apr 3, 2024

Fixes #465

Summary of Changes

Converts global Shortcuts/Keybinds to local keybinds so they do not hijack the keybind from other processes.

Screenshots (if necessary)

Additional context

Discord username (if different from GitHub):

@alepouna alepouna marked this pull request as draft April 3, 2024 09:04
@alepouna alepouna marked this pull request as ready for review April 3, 2024 09:28
@Benjozork
Copy link
Member

Tested, works well

@Benjozork Benjozork merged commit 85a2823 into flybywiresim:master Apr 14, 2024
2 checks passed
Benjozork pushed a commit that referenced this pull request Aug 21, 2024
* convert to local keybinds

* fix lowercase check

* linting

* linting?

* final lint

* final final lint (trust)

* final final FINAL lint (this time for real)

* changelog entry

(cherry picked from commit 85a2823)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer is 'hijacking' keybinds when active
2 participants