Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add possibility of getting latest track versions from fragmenter distribution manifest #477

Merged
merged 12 commits into from
Oct 13, 2024

Conversation

Benjozork
Copy link
Member

@Benjozork Benjozork commented Sep 22, 2024

Summary of Changes

  • Add possibility of getting latest track versions from fragmenter distribution manifest
  • Clean up install state detection logic
  • Clean up update checking logic
  • Add developer setting for forcing use of local configuration

Testing Instructions

  • Make sure addon installing, updating, version switching, removal, etc. works correctly
  • Make sure you cannot get into a broken state by cancelling the install/update/version switch
  • Make sure those operations are correctly blocked when SImBridge or the sim are running

- moved duplicated logic to Installmanager
- removed redundant logic in component render
- removed unneeded boilerplate
src/renderer/components/AddonSection/index.tsx Outdated Show resolved Hide resolved
src/renderer/utils/InstallManager.tsx Show resolved Hide resolved
src/renderer/utils/InstallManager.tsx Outdated Show resolved Hide resolved
src/renderer/components/AddonSection/index.tsx Outdated Show resolved Hide resolved
src/renderer/utils/InstallManager.tsx Show resolved Hide resolved
@Saschl
Copy link
Contributor

Saschl commented Oct 8, 2024

Quality Assurance Tester/Dev Team Report

Discord Username : saschl
Object of testing : 477
Date : 08/10/2024

Testing Process:

Installed A32NX, switched versions. Seems to work properly. Simbridge dependency is being installed if it's not installed yet.

Installed Simbridge, started tried uninstalling. Popup appears and after stopping installation is successful.
-> Note: Simbridge does not seem to shutdown properly when the page on the installer is open. I believe this is already an issue on master
After simbridge is stopped, uninstall works properly.

Cancelled a few installs, state seems to be consistent.
-> Empty folder for the addon is being created in the community folder but not removed again.

Testing Results:
Passed

Negatives:

  • It would be good to show an error if uninstall fails due to certain issues (i.e. file locked/busy which currently happens when simbridge is stopped via the installer, but the process is still running). Right now I only see an error in the console.
    Can be a separate PR imo. Not a blocker.

  • Progress for simbridge (when installed as dependency) is being shown on the aircraft page. If that's expected then pass.

  • Empty folder for the addon is being created in the community folder but not removed again when an install is being cancelled.

Conclusions:

Can see the same "issues" from the negative section in the current release version. Passed then.

Media:

image

@Benjozork Benjozork merged commit 775494d into flybywiresim:master Oct 13, 2024
3 checks passed
Saschl pushed a commit that referenced this pull request Oct 15, 2024
…r distribution manifest (#477)

* build: bump version

* feat: initial commit

* refactor: clean up install state logic

- moved duplicated logic to Installmanager
- removed redundant logic in component render
- removed unneeded boilerplate

* chore: fix lint

* refactor: improvements

* refactor: address review comments

* refactor: address review comments, prefix console logs

* fix: various bug fixes

* chore: typo

* fix: don't finish update check if install in progress

* fix: run checkForUpdates after refreshAddonInstallState to make sure we don't have Unknown status the first time

---------

Co-authored-by: alepouna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants