-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
5 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d6190b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely it would make more sense for num_key[1] to return the 1 key, despite the fact that that's not their order on the keyboard, wouldn't it? In that case, wouldn't it be cleaner to revert the change on line +/-250 (+251, +252) and change line 385 to instead use self.num_keys[1]?
This is just a design consideration, not a bug.