Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Text margins and bgColor #584

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dennislaupman
Copy link

@dennislaupman dennislaupman commented Nov 19, 2016

Added three extra options: marginBefore and marginAfter. It's very useful for creating gDoc styled documents. And Last but not least. I added the bgColor:"#ffff00" option to change the text background color in a color you provide. (Highlight conflicts in a several color combinations and has an other behaviour)

screen shot 2016-11-23 at 14 20 59

Added margin before and after text block option
@dennislaupman dennislaupman changed the title Text margins Added Text margins and bgColor Nov 23, 2016
dennislaupman and others added 2 commits November 23, 2016 14:18
@dennislaupman
Copy link
Author

Hello,

Is it possible to merge this one? Would be nice!

Thanks,

Dennis

docs/text.coffee.md Outdated Show resolved Hide resolved
@dennislaupman
Copy link
Author

Changed it into top and bottom. Can you review it? Would be nice!

@alafr
Copy link
Collaborator

alafr commented Feb 2, 2018

Nice but the bgColor option fails with justified or right-aligned text

@charklewis
Copy link

Any updates on getting this merged? Love the feature!

@blikblum
Copy link
Member

Any updates on getting this merged? Love the feature!

First needs to be rebased, converted to plain JS

Also, fix problems pointed in the discussion

@Mintenker
Copy link

This would still be a nice feature. Any updates?

@blikblum
Copy link
Member

First needs to be rebased, converted to plain JS

Also, fix problems pointed in the discussion

This

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants