@W-15363709 Changes to RestAPI for modern Async/Await #3806
Conversation
libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Extensions/RestClient.swift
Outdated
Show resolved
Hide resolved
|
👍 for getting rid of the warnings in NativeLoginManager. I still see two in RestAPIExplorer (ignore the traitCollection one) |
| self.handleError(request: request, error: error) | ||
| } | ||
|
|
||
| self.view.endEditing(true) |
There was a problem hiding this comment.
what's this change for? is the same call at line 562 still needed?
There was a problem hiding this comment.
ah, that was a copy error. I take that out. Good catch on that one. 🙏
There was a problem hiding this comment.
@bbirman OK, Fixed my goof. Thanks for catching that .
There was a problem hiding this comment.
lgtm! It looks like one of the templates uses the old way too so please update that as well, let me know if you have any questions about that repo!
https://github.com/forcedotcom/SalesforceMobileSDK-Templates/blob/358f7cace478f6458c32f57283e8364e493b8cd5/iOSNativeSwiftEncryptedNotificationTemplate/EncryptedNotificationTemplate/RootViewController.swift#L39
|
@bbirman I made update to the template repo. PR is here forcedotcom/SalesforceMobileSDK-Templates#441 |
No description provided.