Remove unused property #3809
Merged
Remove unused property #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang Static Analysis Issues
Generated by 🚫 Danger |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3809 +/- ##
==========================================
- Coverage 62.75% 61.27% -1.49%
==========================================
Files 224 233 +9
Lines 21361 21879 +518
==========================================
+ Hits 13405 13406 +1
- Misses 7956 8473 +517
|
wmathurin
reviewed
Jan 21, 2025
| @@ -225,9 +225,6 @@ NS_SWIFT_NAME(SalesforceManager) | |||
| */ | |||
| @property (nonatomic, assign) BOOL isLoginWebviewInspectable; | |||
|
|
|||
| /*** Indicates if login via QR Code and UI bridge API is enabled */ | |||
| @property (nonatomic, assign) BOOL isQrCodeLoginEnabled; | |||
There was a problem hiding this comment.
The template sets it (see https://github.com/search?q=repo%3Aforcedotcom%2FSalesforceMobileSDK-Templates%20isQrCodeLoginEnabled&type=code).
@JohnsonEricAtSalesforce what was the idea for that property ?
There was a problem hiding this comment.
👍 I have a commit for the template I'll put up too if we merge this
There was a problem hiding this comment.
@wmathurin - On Android, this property was actually used but in the iOS implementation it wound up not being practical. It can be safely removed.
wmathurin
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.