@W-14212091 Remove userLogout AILTN event #3815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbirman
reviewed
Jan 27, 2025
| @@ -494,7 +493,6 @@ - (void)createAndStoreLogoutEvent:(NSError *)error user:(SFUserAccount*)user { | |||
| NSMutableDictionary *attributes = [[NSMutableDictionary alloc] init]; | |||
| attributes[@"errorCode"] = [NSNumber numberWithInteger:error.code]; | |||
| attributes[@"errorDescription"] = error.localizedDescription; | |||
| [SFSDKEventBuilderHelper createAndStoreEvent:@"userLogout" userAccount:user className:NSStringFromClass([self class]) attributes:attributes]; | |||
There was a problem hiding this comment.
I didn't notice the second line before 👍 . Looks like the containing method isn't needed either?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion here and in stand up, the event doesn't work and it wouldn't be possible to use AILTN to log the scenario where the user's token is revoked because we need the token to publish to AILTN
What to change
Remove this line:
SalesforceMobileSDK-iOS/libs/SalesforceSDKCore/SalesforceSDKCore/Classes/RestAPI/SFRestAPI.m
Line 257 in 821bc4f