Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-17685462 - Update SfapClient to use updated send method #3820

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Crebs
Copy link
Contributor

@Crebs Crebs commented Jan 28, 2025

Updated Depricated request to modern ones

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 61.97%. Comparing base (34ce7f8) to head (a4381ef).
Report is 24 commits behind head on dev.

Files with missing lines Patch % Lines
...ceSDKCore/Classes/RestAPI/SfapAPI/SfapClient.swift 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3820      +/-   ##
==========================================
- Coverage   62.00%   61.97%   -0.04%     
==========================================
  Files         233      233              
  Lines       21654    21878     +224     
==========================================
+ Hits        13427    13559     +132     
- Misses       8227     8319      +92     
Components Coverage Δ
Analytics 81.88% <ø> (-1.26%) ⬇️
Common 68.87% <ø> (+0.08%) ⬆️
Core 50.76% <54.90%> (+0.12%) ⬆️
SmartStore 73.70% <ø> (+<0.01%) ⬆️
MobileSync 87.58% <ø> (ø)
Files with missing lines Coverage Δ
...ceSDKCore/Classes/RestAPI/SfapAPI/SfapClient.swift 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

@Crebs Crebs merged commit 40de376 into forcedotcom:dev Jan 28, 2025
7 of 8 checks passed
@Crebs Crebs deleted the @W-17685462 branch January 28, 2025 21:55
Copy link
Contributor

@wmathurin wmathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants