Replace pkg_resources

[odkhang]

Fixes #185 Replace pkg_resources

Short description of what this resolves:

Replace pkg_resources

Changes proposed in this pull request:

• Replace pkg_resources with import importlib_metadata

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[hongquan]

Please move this import line to the top. Separate import lines to 3 groups as PEP8 recommendation.

[hongquan]

Don't use print. Use logger instead.

[odkhang]

Hi @hongquan ,
I have fixed the code according to your request. Could you please help me review it?

Thank you very much!

[hongquan]

Please don't embed data to log message like this:

logger.error(f"Plugin {self.name} requires you to have {package_name}=={required_version}")

Because when we don't want to emit the log message (by adjusting log level), the variables are still evaluated to build the string.

Please pass the variables as parameters, like this:

logger.error('Plugin %s requires you to have %s==%s', self.name, package_name, required_version)

By this, the variables are only evaluated when the log level matches and the logging system is about to emit messages.

[odkhang]

Hi @hongquan,
I've fixed the logging issue by passing variables as parameters to avoid unnecessary evaluation. Could you please help me review it?