Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of devel branch from tutorial #627

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

kprosise
Copy link
Contributor

A mention of 'platform-devel' found in the 'customizing the platform' tutorial was replaced with 'platform-main'.

Grep'd all the tutorial for any other mentions where not appropriate.

No QA steps performed.

No issues to link, minor fix.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

A mention of 'platform-devel' found in the 'customizing the
platform' tutorial was replaced with 'platform-main'.

Grep'd all the tutorial for any other mentions where *not appropriate*.

No QA steps performed.

No issues to link, minor fix.

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise requested a review from a team November 15, 2023 12:20
@doanac
Copy link
Member

doanac commented Nov 15, 2023

@kprosise kprosise merged commit 4d94ede into foundriesio:main Nov 15, 2023
1 check passed
@kprosise kprosise deleted the remove-devel-from-tutorial branch January 9, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants