-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup ota reference manual #635
Conversation
Docs for fc7fec1 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2506/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kprosise I think you're making a great improvement to our docs with this PR.
However, closer to the end I've completely lost attention.
It would be much easier to grasp what's really changed if this PR is split into individual commits, each targetting a specific problem you tried to fix.
For example, the pure sentence split or a global replacement of target -> Target, would look the best as separate commits.
I know, it is way too late, and you did a lot of great job, so I don't want to force you redoing this.
We may try pursuing this PR as is.
It is just something to consider for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding suggestions...
Docs for 636e9d8 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2508/docs/artifacts/html/index.html |
Docs for 5bf6928 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2509/docs/artifacts/html/index.html |
Docs for 70fbcb1 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2510/docs/artifacts/html/index.html |
Docs for 17e7c19 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2511/docs/artifacts/html/index.html |
Docs for 9ad4fe8 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2512/docs/artifacts/html/index.html |
Docs for 19e771a are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2513/docs/artifacts/html/index.html |
Docs for 1d44971 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2514/docs/artifacts/html/index.html |
842bf5f
to
9384da9
Compare
Grammar and style changes made. Updates to content may be required. QA: Ran linter in editor. Checked rendered output in browser, no rendering issues spotted. Linkcheck encountering issues not believed to be associated with any changes made in this commit. This commit addresses FFTK-2792 This commit applies to FFTK-2730 This commit applies to FFTK-2732 This commit applies to FFTK-2731 This commit applies to FFTK-1702 This commit applies to FFTK-988 Signed-off-by: Katrina Prosise <[email protected]>
9384da9
to
8bd4898
Compare
Docs for 8bd4898 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2519/docs/artifacts/html/index.html |
Added additional suggestions Signed-off-by: Katrina Prosise <[email protected]>
Docs for 42c8519 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2524/docs/artifacts/html/index.html |
Grammar and style changes made.
Updates to content may be required.
QA: Ran linter in editor.
Checked rendered output in browser, no rendering issues spotted. Linkcheck encountering issues not believed to be associated with any changes made in this commit.
This commit addresses FFTK-2792
This commit applies to FFTK-2730
This commit applies to FFTK-2732
This commit applies to FFTK-2731
This commit applies to FFTK-1702
This commit applies to FFTK-988
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.