-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customer facing improvements #781
Merged
kprosise
merged 2 commits into
foundriesio:main
from
vanmaegima:customer-facing-improvements
Jan 8, 2025
Merged
Customer facing improvements #781
kprosise
merged 2 commits into
foundriesio:main
from
vanmaegima:customer-facing-improvements
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many customers are performing git merges/cherry picks that will not bring the git tag information. We rely on that for support, so update the docs accordingly. Signed-off-by: Vanessa Maegima <[email protected]>
vanmaegima
force-pushed
the
customer-facing-improvements
branch
from
January 7, 2025 16:57
c884026
to
c8f5663
Compare
Tim-Anderson
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kprosise
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor suggestions, otherwise it looks good!
Many users want to downgrade the image. This shows how to recreate a target so it's picked by aklite daemon. Signed-off-by: Vanessa Maegima <[email protected]>
vanmaegima
force-pushed
the
customer-facing-improvements
branch
from
January 8, 2025 12:59
c8f5663
to
692beb5
Compare
@kprosise Suggestions applied! Feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.