refactor: use reconciliation date, if set

erpnext/accounts/doctype/payment_entry/payment_entry.py

@@ -1506,16 +1506,18 @@ def add_advance_gl_for_reference(self, gl_entries, invoice):
 			"voucher_detail_no": invoice.name,
 		}
 
-		if self.reconcile_on_advance_payment_date:
+		if self.advance_payment_reconciliation_takes_effect_on == "Advance Payment Date":
 			posting_date = self.posting_date
-		else:
+		elif self.advance_payment_reconciliation_takes_effect_on == "Oldest Of Invoice Or Advance":
 			date_field = "posting_date"
 			if invoice.reference_doctype in ["Sales Order", "Purchase Order"]:
 				date_field = "transaction_date"
 			posting_date = frappe.db.get_value(invoice.reference_doctype, invoice.reference_name, date_field)
 
 			if getdate(posting_date) < getdate(self.posting_date):
 				posting_date = self.posting_date
+		elif self.advance_payment_reconciliation_takes_effect_on == "Reconciliation Date":
+			posting_date = nowdate()
 
 		dr_or_cr, account = self.get_dr_and_account_for_advances(invoice)
 		args_dict["account"] = account