Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: configurable reconciliation dates for Advance Payments #45182

Merged

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Jan 9, 2025

Advance Payments (booked in separate party account) can be configured to have it's reconciliation take effect on the date of reconciliation.

todo:

  • Test cases
  • store reconciliation dates on references; helps on reposting

Deprecated checkbox will be dropped in a later release.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 9, 2025
@ruthra-kumar ruthra-kumar force-pushed the configurable_reconciliation_dates branch from 8f74967 to 38c1e95 Compare January 9, 2025 10:13
@ruthra-kumar ruthra-kumar force-pushed the configurable_reconciliation_dates branch from 38c1e95 to a5d4812 Compare January 9, 2025 14:53
@ruthra-kumar ruthra-kumar force-pushed the configurable_reconciliation_dates branch from a5d4812 to c8e93e7 Compare January 9, 2025 15:12
@ruthra-kumar ruthra-kumar self-assigned this Jan 13, 2025
@ruthra-kumar ruthra-kumar requested review from vorasmit and removed request for vorasmit January 14, 2025 04:40
@ruthra-kumar ruthra-kumar removed their assignment Jan 14, 2025
@ruthra-kumar ruthra-kumar merged commit aea69af into frappe:develop Jan 14, 2025
14 checks passed
ruthra-kumar added a commit that referenced this pull request Jan 14, 2025
…-45182

refactor: configurable reconciliation dates for Advance Payments (backport #45182)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant