refactor: allow users to configure interval for Semi-Auto payment reconciliation #45211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
accounts
needs-tests
ruthra-kumar
force-pushed
the
configurable_cron_interval_and_queue_size
branch
2 times, most recently
from
55b3d0c to
6f55d88
Compare
ruthra-kumar
added
the
squash
User specified interval will be used
ruthra-kumar
force-pushed
the
configurable_cron_interval_and_queue_size
branch
from
6b123f1 to
f625a59
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
…onciliation (#45211) * refactor: configurable interval for reconciliation trigger * refactor: set default value for interval * refactor: configurable queue size * refactor: use patch to setup default cron job * refactor: use 'after_migrate' to setup cron for reconciliation User specified interval will be used * chore: type casting * refactor: use scheduler_event to persist cron * chore: rename field * chore: use configured queue size * chore: remove unwanted field (cherry picked from commit ce9c606)
1 task
ruthra-kumar
added a commit
that referenced
this pull request
Jan 14, 2025
…-45211 refactor: allow users to configure interval for Semi-Auto payment reconciliation (backport #45211)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limitation
Semi-Auto Payment Reconciliation was hard coded to run every 15 min processing only 5 unique
Process Payment Reconciliationdocuments. Initial requirement was to handle small number of parties will large volume of unreconciled invoices.But, for the inverse scenario - thousands of parties but only a dozen or so unreconciled invoices, this interval and queue size is not ideal.
Solution
Making Trigger interval and Queue size configurable.
ToDo:
upstream dependency: frappe/frappe#29122