Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect valuation rate for PI based revaluation (backport #45207) #45218

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: incorrect valuation rate for PI based revaluation (backport #45207) #45218

merged 1 commit into from
Jan 13, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 11, 2025

Steps to replicate the issue

  • Enable "Set Landed Cost Based on Purchase Invoice Rate" in the Buying Settings
  • Make PR with Item A and zero rate
  • Make Purchase invoice with 100 rate
  • Complete the reposting
  • The valuation rate has not changed of the PR
This is an automatic backport of pull request #45207 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from rohitwaghchaure as a code owner January 11, 2025 04:39
@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Jan 11, 2025
@rohitwaghchaure rohitwaghchaure merged commit 4ee6a4e into version-15-hotfix Jan 13, 2025
12 checks passed
@rohitwaghchaure rohitwaghchaure deleted the mergify/bp/version-15-hotfix/pr-45207 branch January 13, 2025 06:55
@rohitwaghchaure
Copy link
Collaborator

@Mergifyio backport version-15

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Jan 13, 2025 •
edited
Loading

backport version-15

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jan 13, 2025
Merged
rohitwaghchaure added a commit that referenced this pull request Jan 13, 2025
@rohitwaghchaure
Merge pull request #45235 from frappe/mergify/bp/version-15/pr-45218
47ab3c5 
fix: incorrect valuation rate for PI based revaluation (backport #45207) (backport #45218)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees

@rohitwaghchaure rohitwaghchaure

Labels
needs-tests This PR needs automated unit-tests. stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rohitwaghchaure